Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 91501200C45 for ; Tue, 28 Mar 2017 18:49:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8EF37160B9B; Tue, 28 Mar 2017 16:49:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D8341160B6B for ; Tue, 28 Mar 2017 18:49:44 +0200 (CEST) Received: (qmail 9147 invoked by uid 500); 28 Mar 2017 16:49:44 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 9137 invoked by uid 99); 28 Mar 2017 16:49:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Mar 2017 16:49:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A0B0DC67A9 for ; Tue, 28 Mar 2017 16:49:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Eb-mR4JWYUk0 for ; Tue, 28 Mar 2017 16:49:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CC3235F2FE for ; Tue, 28 Mar 2017 16:49:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1DE9CE012E for ; Tue, 28 Mar 2017 16:49:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id C7E3F24062 for ; Tue, 28 Mar 2017 16:49:41 +0000 (UTC) Date: Tue, 28 Mar 2017 16:49:41 +0000 (UTC) From: "Benjamin Bannier (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-7016) Make default AWAIT_* duration configurable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 28 Mar 2017 16:49:45 -0000 [ https://issues.apache.org/jira/browse/MESOS-7016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945533#comment-15945533 ] Benjamin Bannier commented on MESOS-7016: ----------------------------------------- Linking MESOS-7318 which is related in the sense that test expectations might also fail when tests are run in e.g., a virtual machine which is for some reason suspended by the host. > Make default AWAIT_* duration configurable > ------------------------------------------ > > Key: MESOS-7016 > URL: https://issues.apache.org/jira/browse/MESOS-7016 > Project: Mesos > Issue Type: Improvement > Components: libprocess, test > Reporter: Benjamin Bannier > > libprocess defines a number of helpers {{AWAIT_*}} to wait for a {{process::Future}} reaching terminal states. These helpers are used in tests. > Currently the default duration to wait before triggering an assertion failure is 15s. This value was chosen as a compromise between failing fast on likely fast developer machines, but also allowing enough time for tests to pass in high-contention environments (e.g., overbooked CI machines). > If a machine is more overloaded than expected, {{Futures}} might take longer to reach the desired state, and tests could fail. Ultimately we should consider running tests with paused clock to eliminate this source of test flakiness, see MESOS-4101, but as an intermediate measure we should make the default timeout duration configurable. > A simple approach might be to expose a build variable allowing users to set at configure/cmake time a desired timeout duration for the setup they are building for. This would allow us to define longer timeouts in the CI build scripts, while keeping default timeouts as short as possible. -- This message was sent by Atlassian JIRA (v6.3.15#6346)