mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-7296) CMake 2.8.10 does not support TIMESTAMP
Date Thu, 23 Mar 2017 22:21:41 GMT

    [ https://issues.apache.org/jira/browse/MESOS-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15939326#comment-15939326
] 

Joseph Wu commented on MESOS-7296:
----------------------------------

Technically, the version of the patch I pushed (same review as the description) fixed this
issue.

https://github.com/apache/mesos/commit/6d7b25adc67af53ba987caf7c9e838b2e2aa85ca#diff-c6be27394bfb1ecb223fc31aa9e796b1

Basically, on non-Windows, the date is calculated via {{date +%s}}.

> CMake 2.8.10 does not support TIMESTAMP
> ---------------------------------------
>
>                 Key: MESOS-7296
>                 URL: https://issues.apache.org/jira/browse/MESOS-7296
>             Project: Mesos
>          Issue Type: Bug
>          Components: build, cmake
>         Environment: Anywhere with CMake 2.x instead of 3.x (specifically 2.8.10).
>            Reporter: Andrew Schwartzmeyer
>            Priority: Trivial
>              Labels: build
>
> The patch https://reviews.apache.org/r/57052/ moved the build time and date info out
of compile definitions and into a build file. While testing, an existent bug was discovered
where the CMake command `string(TIMESTAMP BUILD_TIME "%s" UTC)` is unsupported with CMake
2.8.10. Instead of replacing the variable with the time, it replaces with with "%s".
> This is not a Linux vs Windows bug. This is specifically unsupported in 2.8.10. Configuring
with `cmake3` does not reproduce the bug.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message