Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Date: Fri, 10 Feb 2017 07:21:41 +0000 (UTC)
From: "Adam B (JIRA)" <jira@apache.org>
To: issues@mesos.apache.org
Message-ID: <JIRA.13038473.1485532931000.46268.1486711301715@Atlassian.JIRA>
In-Reply-To: <JIRA.13038473.1485532931000@Atlassian.JIRA>
References: <JIRA.13038473.1485532931000@Atlassian.JIRA> <JIRA.13038473.1485532931765@jira-lw-us.apache.org>
Subject: [jira] [Updated] (MESOS-7020) cgroups::internal::write can
 incorrectly report success
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 10 Feb 2017 07:21:45 -0000


     [ https://issues.apache.org/jira/browse/MESOS-7020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam B updated MESOS-7020:
--------------------------
    Fix Version/s:     (was: 1.3.0)
                   1.2.0

> cgroups::internal::write can incorrectly report success
> -------------------------------------------------------
>
>                 Key: MESOS-7020
>                 URL: https://issues.apache.org/jira/browse/MESOS-7020
>             Project: Mesos
>          Issue Type: Bug
>          Components: cgroups
>    Affects Versions: 1.2.0
>         Environment: CentOS7
>            Reporter: Dmitry Zhuk
>            Assignee: Jie Yu
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> {{cgroups::internal::write}} does not flush stream before checking for errors after writing:
> {code}
>   ofstream file(path.c_str());
> ...
>   file << value;
>   if (file.fail()) {
>     // TODO(jieyu): Does ofstream actually set errno?
>     return ErrnoError();
>   }
> {code}
> Since {{ofstream}} does internal buffering, {{file.fail()}} can return {{false}}, as value hasn't been written to file yet.
> Replacing {{file << value;}} with {{file << value << std::flush;}} makes {{file.fail()}} behave as expected.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)