mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MESOS-7044) Update comments for Queue.get() & Queue.put()
Date Wed, 01 Feb 2017 02:22:51 GMT

     [ https://issues.apache.org/jira/browse/MESOS-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guangya Liu updated MESOS-7044:
-------------------------------
    Priority: Minor  (was: Major)

> Update comments for Queue.get() & Queue.put()
> ---------------------------------------------
>
>                 Key: MESOS-7044
>                 URL: https://issues.apache.org/jira/browse/MESOS-7044
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Guangya Liu
>            Priority: Minor
>
> This is a follow up action from https://reviews.apache.org/r/55852/
> We are now using Queue.get() & Queue.put() to `pop` and `push` elements, and it is
difficult to understand `Queue.get()` can also `pop` an element without reading the code,
it is better use some meaningful names such as `pop/push` or some others.
> https://github.com/apache/mesos/blob/1.1.x/3rdparty/libprocess/include/process/queue.hpp#L34-L70



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message