Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AF6B4200C10 for ; Fri, 20 Jan 2017 02:41:30 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A8C9C160B57; Fri, 20 Jan 2017 01:41:30 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F2C3B160B54 for ; Fri, 20 Jan 2017 02:41:29 +0100 (CET) Received: (qmail 48001 invoked by uid 500); 20 Jan 2017 01:41:29 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 47983 invoked by uid 99); 20 Jan 2017 01:41:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jan 2017 01:41:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C51B1C036F for ; Fri, 20 Jan 2017 01:41:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id IGAN6DLPq-yy for ; Fri, 20 Jan 2017 01:41:28 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 6C6C55F365 for ; Fri, 20 Jan 2017 01:41:27 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AA222E0059 for ; Fri, 20 Jan 2017 01:41:26 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 65D0F2527F for ; Fri, 20 Jan 2017 01:41:26 +0000 (UTC) Date: Fri, 20 Jan 2017 01:41:26 +0000 (UTC) From: "Adam B (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-6553) Update `MesosContainerizerProcess::_launch()` to pass `ContainerLaunchInfo` to launcher->fork()` MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 20 Jan 2017 01:41:30 -0000 [ https://issues.apache.org/jira/browse/MESOS-6553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830997#comment-15830997 ] Adam B commented on MESOS-6553: ------------------------------- Can you (or your shepherd, [~jieyu]?) add the commits and close with appropriate fixVersion? > Update `MesosContainerizerProcess::_launch()` to pass `ContainerLaunchInfo` to launcher->fork()` > ------------------------------------------------------------------------------------------------ > > Key: MESOS-6553 > URL: https://issues.apache.org/jira/browse/MESOS-6553 > Project: Mesos > Issue Type: Task > Reporter: Kevin Klues > Labels: tech-debt > > Currently, we receive a bunch of {{ContainerLaunchInfo}} structs from each of our isolators and extract information from them, which we pass one by one to our {{launcher->fork()}} call in separate parameters. > Instead, we should construct a new {{ContainerLaunchInfo}} which is the concatenation of the ones returned by each isolator, and pass this new one down to {{launcher->fork()}} instead of building up individual arguments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)