mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-6852) Nested container's launch command is not set correctly in docker/runtime isolator.
Date Wed, 11 Jan 2017 17:32:48 GMT

    [ https://issues.apache.org/jira/browse/MESOS-6852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818915#comment-15818915
] 

Jie Yu commented on MESOS-6852:
-------------------------------

commit 5aa289ba119063d75781bc627ee7d2469a3ededb
Author: Gilbert Song <songzihao1990@gmail.com>
Date:   Wed Jan 11 09:01:39 2017 -0800

    Added unit tests for nested container neglected runtime argv.

    These are regression tests for MESOS-6852. This patch includes
    the tests for default image entrypoint or cmd with user defined
    arguments appended for nested container case.

    Review: https://reviews.apache.org/r/55420/

commit f94d7acd9ccd8b5a971701f8bb824cf0ff496539
Author: Gilbert Song <songzihao1990@gmail.com>
Date:   Wed Jan 11 09:01:35 2017 -0800

    Changed mesos test helper createCommandInfo() using optional value.

    The `value` in protobuf `CommandInfo` is an option. We should allow
    `value` to be empty in mesos test helper createCommandInfo(). The
    use case is the empty value with arguments in runtime isolator
    scenario.

    Review: https://reviews.apache.org/r/55419/

commit 0282c42875692e5be0fa3334062ae7f2029b0b11
Author: Gilbert Song <songzihao1990@gmail.com>
Date:   Wed Jan 11 09:01:32 2017 -0800

    Added nested container tests for docker runtime isolator.

    Review: https://reviews.apache.org/r/52612/

commit af11ad3951b80389c26bec5ba99304004cb93dc7
Author: Gilbert Song <songzihao1990@gmail.com>
Date:   Wed Jan 11 09:01:29 2017 -0800

    Fixed appc runtime isolator argv issue for nested container.

    Review: https://reviews.apache.org/r/55413/

commit d09a6ebfc7a1c227e93e5a41baf76e8464020226
Author: Gilbert Song <songzihao1990@gmail.com>
Date:   Wed Jan 11 09:01:24 2017 -0800

    Fixed docker runtime isolator argv issue for nested container.

    For the nested container with docker runtime isolator, the `argv`
    that should be appended to entrypoint[0] or cmd[0] are neglected.
    This case refers to the 2nd row of the runtime isolator logic
    table (sh=0, value=0, argv=1). This patch addresses the issue.

    Review: https://reviews.apache.org/r/55412/

> Nested container's launch command is not set correctly in docker/runtime isolator.
> ----------------------------------------------------------------------------------
>
>                 Key: MESOS-6852
>                 URL: https://issues.apache.org/jira/browse/MESOS-6852
>             Project: Mesos
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Jie Yu
>            Assignee: Gilbert Song
>            Priority: Blocker
>              Labels: runtime-isolator
>             Fix For: 1.2.0
>
>
> We in-correctly append executor's command to the default entrypoint of the image:
> https://github.com/apache/mesos/blob/1.1.0/src/slave/containerizer/mesos/isolators/docker/runtime.cpp#L323-L327
> https://github.com/apache/mesos/blob/1.1.0/src/slave/containerizer/mesos/isolators/docker/runtime.cpp#L350-L354
> This is probably due to the negligence while adding nested container support.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message