mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-6851) make install fails the second time
Date Thu, 05 Jan 2017 09:03:58 GMT

    [ https://issues.apache.org/jira/browse/MESOS-6851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800827#comment-15800827
] 

Benjamin Bannier commented on MESOS-6851:
-----------------------------------------

Is this really an issue? We currently maintain {{uninstall}} targets which would remove these
files so that the following sequence should be supported,
{code}
make install
make uninstall
make install
{code}

I am pretty sure we do not claim to support installing over an existing installation, e.g.,
installing {{mesos-1.1.0}} over an existing {{mesos-0.10.0}} without explicit uninstall of
0.10.0 almost certainly would lead to the prefix containing files not part of 1.1.0 and a
broken installation.

Note that this behavior change was introduced when we moved the install to use automake's
symbolic {{LN_S}} (which often evaluates to {{ln -s}}) instead of a naked {{ln -sf}} [here|https://github.com/apache/mesos/blame/f89f28724f5837ff414dc6cc84e1afb63f3306e5/src/Makefile.am#L2449-L2450].
{{LN_S}} might evaluate to e.g., {{cp}} on platforms or filesystems not supporting soft links.

> make install fails the second time
> ----------------------------------
>
>                 Key: MESOS-6851
>                 URL: https://issues.apache.org/jira/browse/MESOS-6851
>             Project: Mesos
>          Issue Type: Bug
>          Components: build
>            Reporter: James Peach
>
> Run {{make install}} twice and the second time will fail when it tries to overwrite symlinks:
> {code}
> make[4]: Entering directory '/home/jpeach/upstream/mesos/build/src'
> cd //opt/mesos/etc/mesos && \
>   ln -s mesos-agent-env.sh.template mesos-slave-env.sh.template
> ln: failed to create symbolic link 'mesos-slave-env.sh.template': File exists
> Makefile:12952: recipe for target 'copy-template-and-create-symlink' failed
> make[4]: *** [copy-template-and-create-symlink] Error 1
> make[4]: Leaving directory '/home/jpeach/upstream/mesos/build/src'
> Makefile:12487: recipe for target 'install-data-am' failed
> make[3]: *** [install-data-am] Error 2
> make[3]: Leaving directory '/home/jpeach/upstream/mesos/build/src'
> Makefile:12197: recipe for target 'install-am' failed
> make[2]: *** [install-am] Error 2
> make[2]: Leaving directory '/home/jpeach/upstream/mesos/build/src'
> Makefile:12191: recipe for target 'install' failed
> make[1]: *** [install] Error 2
> make[1]: Leaving directory '/home/jpeach/upstream/mesos/build/src'
> Makefile:764: recipe for target 'install-recursive' failed
> make: *** [install-recursive] Error 1
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message