mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-3447) Port svn_tests
Date Thu, 08 Dec 2016 02:45:58 GMT

    [ https://issues.apache.org/jira/browse/MESOS-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730898#comment-15730898
] 

Joseph Wu commented on MESOS-3447:
----------------------------------

{code}
commit b5b1ead3a8c28b8b65f514fd7b030324a735a26d
Author: Alex Clemmer <clemmer.alexander@gmail.com>
Date:   Wed Dec 7 16:57:37 2016 -0800

    Windows: Added APR include path to libprocess configuration.
    
    Partially addresses MESOS-3447, as APR is a dependency of the SVN
    facilities of Stout.
    
    On Unix builds, APR is expected to have been installed on the system
    prior to building Mesos (usually by a package manager). Since Windows
    does not have a package manager or a reasonble way of automatically
    discovering where a package is installed (aside from the registry), our
    CMake build system takes it upon itself to manage these system
    dependencies.  This means that on Windows, we need to configure the
    build to look for the APR headers in our custom-downloaded APR
    repository.  Currently, though, we are not doing this, so when we'll
    hit a compile-time error if we try to build (e.g.) `svn.hpp`.
    
    This commit will introduce the APR include paths as part of the build
    against Stout. Since Stout is a header-only library, it is (right now)
    incumbent on whoever is bundling Stout up to manage the third-party
    dependencies of Stout. In our current implementation, libprocess manages
    the APR dependency for Stout, hence, we put this logic in libprocess.
    
    Review: https://reviews.apache.org/r/54462/
{code}

> Port svn_tests
> --------------
>
>                 Key: MESOS-3447
>                 URL: https://issues.apache.org/jira/browse/MESOS-3447
>             Project: Mesos
>          Issue Type: Task
>          Components: stout
>            Reporter: Alex Clemmer
>            Assignee: Alex Clemmer
>              Labels: mesosphere, stout
>
> Should be trivial if we have libapr and libsvn building and linking correctly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message