Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 91BAD200BB9 for ; Mon, 7 Nov 2016 20:42:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 905CD160B14; Mon, 7 Nov 2016 19:42:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 0C5D6160AE0 for ; Mon, 7 Nov 2016 20:41:59 +0100 (CET) Received: (qmail 34866 invoked by uid 500); 7 Nov 2016 19:41:59 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 34841 invoked by uid 99); 7 Nov 2016 19:41:59 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Nov 2016 19:41:59 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 1F3852C0D55 for ; Mon, 7 Nov 2016 19:41:59 +0000 (UTC) Date: Mon, 7 Nov 2016 19:41:59 +0000 (UTC) From: "Joris Van Remoortere (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-4638) versioning preprocessor macros MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 07 Nov 2016 19:42:00 -0000 [ https://issues.apache.org/jira/browse/MESOS-4638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645204#comment-15645204 ] Joris Van Remoortere commented on MESOS-4638: --------------------------------------------- {{0.28.3}} {code} commit 6408c54e0327ab864d4e193814ee69bcd24985df Author: Zhitao Li Date: Wed Aug 17 09:34:27 2016 -0700 Introduce MESOS_{MAJOR|MINOR|PATCH}_VERSION_NUM macros. This makes version based conditional compiling much easier for module writers. Review: https://reviews.apache.org/r/50992/ {code} > versioning preprocessor macros > ------------------------------ > > Key: MESOS-4638 > URL: https://issues.apache.org/jira/browse/MESOS-4638 > Project: Mesos > Issue Type: Bug > Components: c++ api > Reporter: James Peach > Assignee: Zhitao Li > Fix For: 0.28.3, 1.0.2, 1.1.0 > > > The macros in {{version.hpp}} cannot be used for conditional build because they are strings not integers. It would be helpful to have integer versions of these for conditionally building code against different versions of the Mesos API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)