Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4A448200B9F for ; Tue, 11 Oct 2016 16:01:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 490BC160AF4; Tue, 11 Oct 2016 14:01:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 98E23160AD2 for ; Tue, 11 Oct 2016 16:01:21 +0200 (CEST) Received: (qmail 17575 invoked by uid 500); 11 Oct 2016 14:01:20 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 17541 invoked by uid 99); 11 Oct 2016 14:01:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Oct 2016 14:01:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7EEDE2C4C71 for ; Tue, 11 Oct 2016 14:01:20 +0000 (UTC) Date: Tue, 11 Oct 2016 14:01:20 +0000 (UTC) From: "Stephan Erb (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-6281) Document how executors can obtain the IP address of the container MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 11 Oct 2016 14:01:22 -0000 [ https://issues.apache.org/jira/browse/MESOS-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15565487#comment-15565487 ] Stephan Erb commented on MESOS-6281: ------------------------------------ From the perspective of an executor author, I would prefer if the multiple IP-addresses attached to the network namespace of the executor are made readily available in a protobuf. This implies that no custom and potentially flaky code relying on a combination of {{LIBPROCESS_IP}} or {{getaddrinfo}} is required. Therefore the question: Would it be possible to move or duplicate this [Slave::_statusUpdate code|https://github.com/apache/mesos/blob/1fe48d388af378176be02b814bb3c7109b90a40d/src/slave/slave.cpp#L3820-L3824] also to (for example) [ExecutorProcess.runTask|https://github.com/apache/mesos/blob/master/src/exec/exec.cpp#L331]? Or would this violate assumptions or standards that TaskInfo is only ever modified by the framework submitting the task? /cc [~anandmazumdar] [~zhitao] > Document how executors can obtain the IP address of the container > ----------------------------------------------------------------- > > Key: MESOS-6281 > URL: https://issues.apache.org/jira/browse/MESOS-6281 > Project: Mesos > Issue Type: Improvement > Reporter: Zameer Manji > Assignee: Avinash Sridharan > Priority: Minor > > From the discussion in #containerizer on Slack. > Documentation would be nice on the best practice on how an executor can obtain the IP address of the container. Some options were discussed: > * Should it check {{LIBPROCESS_IP}}? > * Should it use {{getaddrinfo(3)}}? > * Should {{NetworkInfo}} be exposed to the executor? > A concrete use case of this would be for thermos (Aurora's executor). It needs to figure out an ip address to announce to ZK for discovery. -- This message was sent by Atlassian JIRA (v6.3.4#6332)