Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2DC1F200BA9 for ; Sun, 23 Oct 2016 21:12:00 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2C48B160AFC; Sun, 23 Oct 2016 19:12:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9B90F160ADF for ; Sun, 23 Oct 2016 21:11:59 +0200 (CEST) Received: (qmail 41186 invoked by uid 500); 23 Oct 2016 19:11:58 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 41170 invoked by uid 99); 23 Oct 2016 19:11:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Oct 2016 19:11:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A66322C001E for ; Sun, 23 Oct 2016 19:11:58 +0000 (UTC) Date: Sun, 23 Oct 2016 19:11:58 +0000 (UTC) From: "haosdent (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-5103) Enhance mesos-health-check to send v1:: TaskHealthStatus message MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 23 Oct 2016 19:12:00 -0000 [ https://issues.apache.org/jira/browse/MESOS-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600160#comment-15600160 ] haosdent commented on MESOS-5103: --------------------------------- After check the code, I think it would be better to keep it in messages.proto because it only be used internally. > Enhance mesos-health-check to send v1:: TaskHealthStatus message > ---------------------------------------------------------------- > > Key: MESOS-5103 > URL: https://issues.apache.org/jira/browse/MESOS-5103 > Project: Mesos > Issue Type: Bug > Reporter: Qian Zhang > Assignee: haosdent > > The existing {{mesos-health-check}} (https://github.com/apache/mesos/blob/master/src/health-check/main.cpp) can only send the unversioned {{TaskHealthStatus}} message. However, with the new Executor HTTP Library, there will be executor which is based on v1 HTTP executor API and all the protobuf messages used by it should be v1 as well (e.g., {{v1::TaskHealthStatus}}). > So we may either modify the existing {{mesos-health-check}} binary to send {{v1::TaskHealthStatus}} messages in addition to the unversioned ones or create a new binary for versioned health checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)