mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier (JIRA)" <j...@apache.org>
Subject [jira] [Created] (MESOS-6428) Mesos containerizer helper function signalSafeWriteStatus is not AS-Safe
Date Thu, 20 Oct 2016 14:49:58 GMT
Benjamin Bannier created MESOS-6428:
---------------------------------------

             Summary: Mesos containerizer helper function signalSafeWriteStatus is not AS-Safe
                 Key: MESOS-6428
                 URL: https://issues.apache.org/jira/browse/MESOS-6428
             Project: Mesos
          Issue Type: Bug
          Components: containerization
    Affects Versions: 1.1.0
            Reporter: Benjamin Bannier


In {{src/slave/containerizer/mesos/launch.cpp}} a helper function {{signalSafeWriteStatus}}
is defined. Its name seems to suggest that this function is safe to call in e.g., signal handlers,
and it is used in this file's {{signalHandler}} for exactly that purpose.

Currently this function is not AS-Safe since it e.g., allocates memory via construction of
{{string}} instances, and might destructively modify {{errno}}.

We should clean up this function to be in fact AS-Safe.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message