mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-5103) Enhance mesos-health-check to send v1:: TaskHealthStatus message
Date Sun, 23 Oct 2016 19:11:58 GMT

    [ https://issues.apache.org/jira/browse/MESOS-5103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600160#comment-15600160
] 

haosdent commented on MESOS-5103:
---------------------------------

After check the code, I think it would be better to keep it in messages.proto because it only
be used internally.

> Enhance mesos-health-check to send v1:: TaskHealthStatus message
> ----------------------------------------------------------------
>
>                 Key: MESOS-5103
>                 URL: https://issues.apache.org/jira/browse/MESOS-5103
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Qian Zhang
>            Assignee: haosdent
>
> The existing {{mesos-health-check}} (https://github.com/apache/mesos/blob/master/src/health-check/main.cpp)
can only send the unversioned {{TaskHealthStatus}} message. However, with the new Executor
HTTP Library, there will be executor which is based on v1 HTTP executor API and all the protobuf
messages used by it should be v1 as well (e.g., {{v1::TaskHealthStatus}}).
> So we may either modify the existing {{mesos-health-check}} binary to send {{v1::TaskHealthStatus}}
messages in addition to the unversioned ones or create a new binary for versioned health checks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message