mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-6182) LinuxRootfs::create ignores failures from adding non-existing files
Date Fri, 16 Sep 2016 13:38:20 GMT

    [ https://issues.apache.org/jira/browse/MESOS-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496363#comment-15496363
] 

Alexander Rukletsov commented on MESOS-6182:
--------------------------------------------

As a first thing, can we make {{LinuxRootfs::create()}} return an error in case {{os::realpath()}}
returns {{None()}}, which indicates the file can't be found?

> LinuxRootfs::create ignores failures from adding non-existing files
> -------------------------------------------------------------------
>
>                 Key: MESOS-6182
>                 URL: https://issues.apache.org/jira/browse/MESOS-6182
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Benjamin Bannier
>            Assignee: Benjamin Bannier
>
> {{LinuxRootfs::create}} attempts to add a hardcoded list of files to the created rootfs.
However, if a file does not exist no failure is created, but the file will be missing from
the rootfs.
> This can then lead to failures in tests using the rootfs and relying on files in it.
> We should make failures to compose the planned rootfs explicit so users of this test
code know what they can rely on.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message