mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-6181) The logic for BadACLNoPrincipal and BadACLDropCreateAndDestroy is not correct
Date Tue, 27 Sep 2016 07:13:20 GMT

    [ https://issues.apache.org/jira/browse/MESOS-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525325#comment-15525325
] 

Guangya Liu commented on MESOS-6181:
------------------------------------

Thanks [~greggomann] Agree for #1.

For #2, take {{PersistentVolumeTest, BadACLNoPrincipal}} as an example, in https://github.com/apache/mesos/blob/master/src/tests/persistent_volume_tests.cpp#L1626
, it is expecting {{EXPECT_TRUE(Resources(offer.resources()).contains(volume));}} , but it
is not using the latest offer but it is still using the offer https://github.com/apache/mesos/blob/master/src/tests/persistent_volume_tests.cpp#L1599
revived, this is not accurate, we should use the offer after {{acceptOffers}} , we need to
make sure that the volume is still in the new offer after allocation interval, comments?

> The logic for BadACLNoPrincipal and BadACLDropCreateAndDestroy is not correct
> -----------------------------------------------------------------------------
>
>                 Key: MESOS-6181
>                 URL: https://issues.apache.org/jira/browse/MESOS-6181
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Guangya Liu
>            Assignee: Guangya Liu
>
> Two issues for those two test cases:
> 1) No need to add `{}` in the test case as there is no need to add `{}`, adding the `{}`
will cause the driver decline a non exist offer.
> 2) If destroy volume failed, we should get the last offer to make sure that the last
offer also contain the volume resource.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message