mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-5821) Clean up the billions of compiler warnings on MSVC
Date Tue, 27 Sep 2016 00:10:20 GMT

    [ https://issues.apache.org/jira/browse/MESOS-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15524573#comment-15524573
] 

Joseph Wu commented on MESOS-5821:
----------------------------------

{code}
commit bd7749690efad81e4161820f83309fe9c431f872
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 13:48:04 2016 -0700

    Windows: Added socket wrapper functions to deal with warnings.
    
    The Windows equivalents of `bind`, `connect`, `send`, and `recv` have
    `int` in their function prototype instead of `size_t`.  This adds
    wrapper functions that cast appropriately.
    
    Review: https://reviews.apache.org/r/52194/
{code}
{code}
commit dda9684e621782a2dc9032a57b07a85a4d38dfe6
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 13:56:20 2016 -0700

    Replaced some socket functions with Stout wrappers.
    
    Review: https://reviews.apache.org/r/52195/
{code}
{code}
commit 3e4c3a982a057c21e9e854c97134d1142856f3aa
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 14:01:08 2016 -0700

    Fixed warnings in `process/system.hpp`.
    
    There was an implicit conversion from `uint64_t` to `double`.
    
    Review: https://reviews.apache.org/r/52200/
{code}
{code}
commit e8bbbc56001e07726f3a7f9cf1c219e759a96a9a
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 15:03:42 2016 -0700

    Fixed warning in `process/timer.hpp`.
    
    We were unnecessarily casting from `long` to `uint64_t`.
    
    Review: https://reviews.apache.org/r/52201/
{code}
{code}
commit 187f632f075fe9e6dd50332bf7b2a56ef92af8ba
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 15:09:48 2016 -0700

    Fixed warnings in message encoders and decoders.
    
    Removes a couple implicit type casts.
    
    Review: https://reviews.apache.org/r/52202/
{code}
{code}
commit 7d56c0dd7842d7a6c31cbe3f0c6a6f433f5054b6
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 15:21:35 2016 -0700

    Fixed warning in `metrics.hpp`.
    
    We were implicitly casting a `size_t` to `double`.
    
    Review: https://reviews.apache.org/r/52203/
{code}
{code}
commit 4c5b9211521731712aa5787ba265eab2011b6db9
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 15:28:28 2016 -0700

    Fixed warning in `socket.hpp`.
    
    Removes a signed-unsigned comparison warning.
    
    Review: https://reviews.apache.org/r/52204/
{code}
{code}
commit d6ec79b07bbba8c9be4ae7ce40686c76884fbbed
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 15:37:20 2016 -0700

    Windows: Fixed type mismatch in `windows/os.hpp`.
    
    Removes an implicit cast from `size_t` to `DWORD`.
    
    Review: https://reviews.apache.org/r/52206/
{code}
{code}
commit 9d667af10948e1e2ad94fd6e9dbbf77788141c09
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 15:49:35 2016 -0700

    Windows: Fixed warning in `windows/fs.hpp`.
    
    Removes an implicit cast from `ULONGLONG` to `double`.
    
    Review: https://reviews.apache.org/r/52207/
{code}
{code}
commit 958690f4a16ec979ab3597df2283058bf0714bdc
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 15:53:20 2016 -0700

    Fixed some warnings in `health_checker.cpp`.
    
    Removed a couple of implicit casts from `double` to `int64_t`.
    
    Review: https://reviews.apache.org/r/52208/
{code}
{code}
commit 9ee31f61946be15833713fe20ae060b56e26fc0d
Author: Daniel Pravat <dpravat@outlook.com>
Date:   Mon Sep 26 16:25:46 2016 -0700

    Fixed warning in `slave.cpp`.
    
    Removed an implicit cast from `size_t` to `double`.
    
    Review: https://reviews.apache.org/r/52209/
{code}

> Clean up the billions of compiler warnings on MSVC
> --------------------------------------------------
>
>                 Key: MESOS-5821
>                 URL: https://issues.apache.org/jira/browse/MESOS-5821
>             Project: Mesos
>          Issue Type: Bug
>          Components: slave
>            Reporter: Alex Clemmer
>            Assignee: Daniel Pravat
>              Labels: mesosphere, slave
>
> Clean builds of Mesos on Windows will result in approximately {{5800 Warning(s)}} or
more.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message