Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DA365200B65 for ; Wed, 17 Aug 2016 19:49:21 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D8BA9160A8C; Wed, 17 Aug 2016 17:49:21 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 535AE160A6C for ; Wed, 17 Aug 2016 19:49:21 +0200 (CEST) Received: (qmail 95140 invoked by uid 500); 17 Aug 2016 17:49:20 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 95129 invoked by uid 99); 17 Aug 2016 17:49:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2016 17:49:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6B9A72C0032 for ; Wed, 17 Aug 2016 17:49:20 +0000 (UTC) Date: Wed, 17 Aug 2016 17:49:20 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-6038) Prevent leaking allocated memory for Promises MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 17 Aug 2016 17:49:22 -0000 [ https://issues.apache.org/jira/browse/MESOS-6038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425019#comment-15425019 ] ASF GitHub Bot commented on MESOS-6038: --------------------------------------- Github user haosdent commented on the issue: https://github.com/apache/mesos/pull/157 By the way, copy a comment from @jpeach in https://mesos.slack.com/messages/cxx/ ``` Promise promise = Promise(); why not just ```Promise promise;``` `` > Prevent leaking allocated memory for Promises > --------------------------------------------- > > Key: MESOS-6038 > URL: https://issues.apache.org/jira/browse/MESOS-6038 > Project: Mesos > Issue Type: Bug > Components: c++ api, libprocess > Reporter: Aaron Wood > Priority: Minor > Labels: github-import, patch > > I had found a few places where these Promise objects were leaking. Once the Future was returned there was no way to free the memory for the Promise object that had been allocated thus causing the leak. > https://reviews.apache.org/r/51068/ > https://github.com/apache/mesos/pull/157 -- This message was sent by Atlassian JIRA (v6.3.4#6332)