mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MESOS-6021) Consolidate two `Containerizer::launch` methods into one.
Date Sun, 14 Aug 2016 18:38:20 GMT

     [ https://issues.apache.org/jira/browse/MESOS-6021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jie Yu updated MESOS-6021:
--------------------------
    Labels: mesosphere  (was: mesosp)

> Consolidate two `Containerizer::launch` methods into one.
> ---------------------------------------------------------
>
>                 Key: MESOS-6021
>                 URL: https://issues.apache.org/jira/browse/MESOS-6021
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Jie Yu
>            Assignee: Gilbert Song
>              Labels: mesosphere
>             Fix For: 1.1.0
>
>
> Looks like keeping both of them is not necessary.
> {code}
>   // Launch a containerized executor. Returns true if launching this
>   // ExecutorInfo is supported and it has been launched, otherwise
>   // false or a failure is something went wrong.
>   virtual process::Future<bool> launch(
>       const ContainerID& containerId,
>       const ExecutorInfo& executorInfo,
>       const std::string& directory,
>       const Option<std::string>& user,
>       const SlaveID& slaveId,
>       const process::PID<Slave>& slavePid,
>       bool checkpoint) = 0;
>   // Launch a containerized task. Returns true if launching this
>   // TaskInfo/ExecutorInfo is supported and it has been launched,
>   // otherwise false or a failure is something went wrong.
>   // TODO(nnielsen): Obsolete the executorInfo argument when the slave
>   // doesn't require executors to run standalone tasks.
>   virtual process::Future<bool> launch(
>       const ContainerID& containerId,
>       const TaskInfo& taskInfo,
>       const ExecutorInfo& executorInfo,
>       const std::string& directory,
>       const Option<std::string>& user,
>       const SlaveID& slaveId,
>       const process::PID<Slave>& slavePid,
>       bool checkpoint) = 0;
> {code}
> We can just make `taskInfo` optional.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message