Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D65A1200B14 for ; Sat, 18 Jun 2016 08:41:06 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D4DED160A63; Sat, 18 Jun 2016 06:41:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4E994160A26 for ; Sat, 18 Jun 2016 08:41:06 +0200 (CEST) Received: (qmail 20052 invoked by uid 500); 18 Jun 2016 06:41:05 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 20033 invoked by uid 99); 18 Jun 2016 06:41:05 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 Jun 2016 06:41:05 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 4B7B12C1F61 for ; Sat, 18 Jun 2016 06:41:05 +0000 (UTC) Date: Sat, 18 Jun 2016 06:41:05 +0000 (UTC) From: "Zhitao Li (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-5642) Move include/mesos/v1/master/allocator.proto to its own directory and package MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 18 Jun 2016 06:41:07 -0000 [ https://issues.apache.org/jira/browse/MESOS-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337609#comment-15337609 ] Zhitao Li commented on MESOS-5642: ---------------------------------- [~vinodkone], given this changes output package of struct and could be considered as "backward incompatible", I think we should include in 1.0.0. Can you take a look at the fix at https://reviews.apache.org/r/48902/? Thanks. > Move include/mesos/v1/master/allocator.proto to its own directory and package > ----------------------------------------------------------------------------- > > Key: MESOS-5642 > URL: https://issues.apache.org/jira/browse/MESOS-5642 > Project: Mesos > Issue Type: Bug > Components: HTTP API > Reporter: Zhitao Li > Assignee: Zhitao Li > Fix For: 1.0.0 > > > Right now, all protobuf used in `include/mesos/v1` is in their own directory and package except for allocator. > We should do the same for it for both consistency, as well as protobuf compiler friendliness (e.g. golang compiler doesn't work well when two .proto files generates messages into same package). -- This message was sent by Atlassian JIRA (v6.3.4#6332)