mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhitao Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-5642) Move include/mesos/v1/master/allocator.proto to its own directory and package
Date Sat, 18 Jun 2016 06:41:05 GMT

    [ https://issues.apache.org/jira/browse/MESOS-5642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337609#comment-15337609
] 

Zhitao Li commented on MESOS-5642:
----------------------------------

[~vinodkone], given this changes output package of struct and could be considered as "backward
incompatible", I think we should include in 1.0.0.

Can you take a look at the fix at https://reviews.apache.org/r/48902/? Thanks.

> Move include/mesos/v1/master/allocator.proto to its own directory and package
> -----------------------------------------------------------------------------
>
>                 Key: MESOS-5642
>                 URL: https://issues.apache.org/jira/browse/MESOS-5642
>             Project: Mesos
>          Issue Type: Bug
>          Components: HTTP API
>            Reporter: Zhitao Li
>            Assignee: Zhitao Li
>             Fix For: 1.0.0
>
>
> Right now, all protobuf used in `include/mesos/v1` is in their own directory and package
except for allocator.
> We should do the same for it for both consistency, as well as protobuf compiler friendliness
(e.g. golang compiler doesn't work well when two .proto files generates messages into same
package).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message