mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tomasz Janiszewski (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MESOS-3243) Replace NULL with nullptr
Date Sun, 05 Jun 2016 08:15:59 GMT

    [ https://issues.apache.org/jira/browse/MESOS-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15315765#comment-15315765
] 

Tomasz Janiszewski edited comment on MESOS-3243 at 6/5/16 8:15 AM:
-------------------------------------------------------------------

I've checked them all at once. Looks good. Nulls only preserved in protobuf autogenerated
code.
Checked using:
{code}
git grep -w NULL
{code}



was (Author: janisz):
I've checked them all at once. Looks good. Nulls only preserved in protobuf autogenerated
code.
Checked using:
{code}
find src -name "*.[hc]pp" | xargs -P 4 grep -e '\bNULL\b'    
find include -name "*.[hc]pp" | xargs -P 4 grep -e '\bNULL\b'
find 3rdparty -name "*.[hc]pp" | xargs -P 4 grep -e '\bNULL\b'
{code}

> Replace NULL with nullptr
> -------------------------
>
>                 Key: MESOS-3243
>                 URL: https://issues.apache.org/jira/browse/MESOS-3243
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Michael Park
>            Assignee: Tomasz Janiszewski
>             Fix For: 1.0.0
>
>
> As part of the C++ upgrade, it would be nice to move our use of {{NULL}} over to use
{{nullptr}}. I think it would be an interesting exercise to do this with {{clang-modernize}}
using the [nullptr transform|http://clang.llvm.org/extra/UseNullptrTransform.html] (although
it's probably just as easy to use {{sed}}).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message