mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yong Tang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-4868) PersistentVolumeTests do not need to set up ACLs.
Date Fri, 04 Mar 2016 22:50:40 GMT

    [ https://issues.apache.org/jira/browse/MESOS-4868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180690#comment-15180690
] 

Yong Tang commented on MESOS-4868:
----------------------------------

Added Review Request: https://reviews.apache.org/r/44408/

> PersistentVolumeTests do not need to set up ACLs.
> -------------------------------------------------
>
>                 Key: MESOS-4868
>                 URL: https://issues.apache.org/jira/browse/MESOS-4868
>             Project: Mesos
>          Issue Type: Improvement
>          Components: technical debt, test
>            Reporter: Joseph Wu
>            Assignee: Yong Tang
>              Labels: mesosphere, newbie, test
>
> The {{PersistentVolumeTest}} s have a custom helper for setting up ACLs in the {{master::Flags}}:
> {code}
> ACLs acls;
>     hashset<string> roles;
>     foreach (const FrameworkInfo& framework, frameworks) {
>       mesos::ACL::RegisterFramework* acl = acls.add_register_frameworks();
>       acl->mutable_principals()->add_values(framework.principal());
>       acl->mutable_roles()->add_values(framework.role());
>       roles.insert(framework.role());
>     }
>     flags.acls = acls;
>     flags.roles = strings::join(",", roles);
> {code}
> This is no longer necessary with implicit roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message