mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-4112) Clean up libprocess gtest macros
Date Sat, 26 Mar 2016 18:15:25 GMT

    [ https://issues.apache.org/jira/browse/MESOS-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213140#comment-15213140
] 

Michael Park commented on MESOS-4112:
-------------------------------------

[~yongtang] Thanks for the patch! I've committed it. Could you follow up with a patch to use
the versions that we added?
We should be able to find all of the instances of them by grepping for {{EQ(true}} and {{EQ(false}}.

Regarding (3) and (4), I think we should do (3) but leave (4) as-is for now.

> Clean up libprocess gtest macros
> --------------------------------
>
>                 Key: MESOS-4112
>                 URL: https://issues.apache.org/jira/browse/MESOS-4112
>             Project: Mesos
>          Issue Type: Task
>          Components: libprocess, test
>            Reporter: Michael Park
>            Assignee: Yong Tang
>
> This ticket is regarding the libprocess gtest helpers in {{3rdparty/libprocess/include/process/gtest.hpp}}.
> The pattern in this file seems to be a set of macros:
> * {{AWAIT_ASSERT_<STATE>_FOR}}
> * {{AWAIT_ASSERT_<STATE>}} -- default of 15 seconds
> * {{AWAIT_<STATE>\_FOR}} -- alias for {{AWAIT_ASSERT_<STATE>_FOR}}
> * {{AWAIT_<STATE>}} -- alias for {{AWAIT_ASSERT_<STATE>}}
> * {{AWAIT_EXPECT_<STATE>_FOR}}
> * {{AWAIT_EXPECT_<STATE>}} -- default of 15 seconds
> (1) {{AWAIT_EQ_FOR}} should be added for completeness.
> (2) In {{gtest}}, we've got {{EXPECT_EQ}} as well as the {{bool}}-specific versions:
{{EXPECT_TRUE}} and {{EXPECT_FALSE}}.
> We should adopt this pattern in these helpers as well. Keeping the pattern above in mind,
the following are missing:
> * {{AWAIT_ASSERT_TRUE_FOR}}
> * {{AWAIT_ASSERT_TRUE}}
> * {{AWAIT_ASSERT_FALSE_FOR}}
> * {{AWAIT_ASSERT_FALSE}}
> * {{AWAIT_EXPECT_TRUE_FOR}}
> * {{AWAIT_EXPECT_FALSE_FOR}}
> (3) There are HTTP response related macros at the bottom of the file, e.g. {{AWAIT_EXPECT_RESPONSE_STATUS_EQ}},
however these are missing their {{ASSERT}} counterparts.
> (4) The reason for (3) presumably is because we reach for {{EXPECT}} over {{ASSERT}}
in general due to the test suite crashing behavior of {{ASSERT}}. If this is the case, it
would be worthwhile considering whether macros such as {{AWAIT_READY}} should alias {{AWAIT_EXPECT_READY}}
rather than {{AWAIT_ASSERT_READY}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message