Return-Path: X-Original-To: apmail-mesos-issues-archive@minotaur.apache.org Delivered-To: apmail-mesos-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 667C218356 for ; Sat, 27 Feb 2016 04:27:19 +0000 (UTC) Received: (qmail 71427 invoked by uid 500); 27 Feb 2016 04:27:19 -0000 Delivered-To: apmail-mesos-issues-archive@mesos.apache.org Received: (qmail 71224 invoked by uid 500); 27 Feb 2016 04:27:19 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 71171 invoked by uid 99); 27 Feb 2016 04:27:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 27 Feb 2016 04:27:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7D56C2C1F7E for ; Sat, 27 Feb 2016 04:27:18 +0000 (UTC) Date: Sat, 27 Feb 2016 04:27:18 +0000 (UTC) From: "Michael Park (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MESOS-4693) Variable shadowing in HookManager::slavePreLaunchDockerHook MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MESOS-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Park updated MESOS-4693: -------------------------------- Shepherd: Kapil Arya (was: Joris Van Remoortere) > Variable shadowing in HookManager::slavePreLaunchDockerHook > ----------------------------------------------------------- > > Key: MESOS-4693 > URL: https://issues.apache.org/jira/browse/MESOS-4693 > Project: Mesos > Issue Type: Bug > Components: modules > Affects Versions: 0.27.0 > Reporter: Kevin Devroede > Assignee: Kevin Devroede > Fix For: 0.28.0, 0.27.2 > > > It looks like the {{name}} parameter in {{HookManager::slavePreLaunchDockerHook}} is shadowed by the hook name defined in the {{foreach (const string& name, availableHooks.keys())}}. > Due to this, the hook receives its own name as a parameter instead of the container name. It seems to be the only method of HookManager affected by this shadowing. > See: https://github.com/apache/mesos/blob/0.27.0/src/hook/manager.cpp#L203 > If that's really a bug, I'd be happy to submit a patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)