mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MESOS-4633) Tests will dereference stack allocated agent objects upon assertion/expectation failure.
Date Tue, 16 Feb 2016 22:16:18 GMT

    [ https://issues.apache.org/jira/browse/MESOS-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149225#comment-15149225
] 

Joseph Wu edited comment on MESOS-4633 at 2/16/16 10:15 PM:
------------------------------------------------------------

|| WIP Reviews || Summary ||
| https://reviews.apache.org/r/43613/ | Refactor of {{cluster::}} helpers |
| https://reviews.apache.org/r/43614/ | Change {{StartSlave}}/{{StartMaster}} helpers |
| https://reviews.apache.org/r/43629/
https://reviews.apache.org/r/43630/ | Outlier test changes |
| https://reviews.apache.org/r/43615/ | Tons of similar test changes |


was (Author: kaysoky):
|| WIP Reviews || Summary ||
| https://reviews.apache.org/r/43613/ | Refactor of {{cluster::}} helpers |
| https://reviews.apache.org/r/43614/ | Change {{StartSlave}}/{{StartMaster}} helpers |
| https://reviews.apache.org/r/43615/ | Tons and tons of test changes |
| ??? | Outlier test changes |

> Tests will dereference stack allocated agent objects upon assertion/expectation failure.
> ----------------------------------------------------------------------------------------
>
>                 Key: MESOS-4633
>                 URL: https://issues.apache.org/jira/browse/MESOS-4633
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Joseph Wu
>            Assignee: Joseph Wu
>              Labels: flaky, mesosphere, tech-debt, test
>
> Tests that use the {{StartSlave}} test helper are generally fragile when the test fails
an assert/expect in the middle of the test.  This is because the {{StartSlave}} helper takes
raw pointer arguments, which may be stack-allocated.
> In case of an assert failure, the test immediately exits (destroying stack allocated
objects) and proceeds onto test cleanup.  The test cleanup may dereference some of these destroyed
objects, leading to a test crash like:
> {code}
> [18:27:36][Step 8/8] F0204 18:27:35.981302 23085 logging.cpp:64] RAW: Pure virtual method
called
> [18:27:36][Step 8/8]     @     0x7f7077055e1c  google::LogMessage::Fail()
> [18:27:36][Step 8/8]     @     0x7f707705ba6f  google::RawLog__()
> [18:27:36][Step 8/8]     @     0x7f70760f76c9  __cxa_pure_virtual
> [18:27:36][Step 8/8]     @           0xa9423c  mesos::internal::tests::Cluster::Slaves::shutdown()
> [18:27:36][Step 8/8]     @          0x1074e45  mesos::internal::tests::MesosTest::ShutdownSlaves()
> [18:27:36][Step 8/8]     @          0x1074de4  mesos::internal::tests::MesosTest::Shutdown()
> [18:27:36][Step 8/8]     @          0x1070ec7  mesos::internal::tests::MesosTest::TearDown()
> {code}
> The {{StartSlave}} helper should take {{shared_ptr}} arguments instead.
> This also means that we can remove the {{Shutdown}} helper from most of these tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message