mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Mahler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-2814) os::read should have one implementation
Date Wed, 03 Feb 2016 22:43:39 GMT

    [ https://issues.apache.org/jira/browse/MESOS-2814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131290#comment-15131290
] 

Benjamin Mahler commented on MESOS-2814:
----------------------------------------

Yep I understand this, thanks for clarifying. I just want the stale description to be updated
(this description refers to non-existent char* signature which I assume was passing a buffer
in the past, and there are now 3 implementations).

{quote}
All three overloads of the function can currently produce surprisingly different results in
their independent implementations
{quote}

Can you clarify this point in the description as well?

> os::read should have one implementation
> ---------------------------------------
>
>                 Key: MESOS-2814
>                 URL: https://issues.apache.org/jira/browse/MESOS-2814
>             Project: Mesos
>          Issue Type: Improvement
>          Components: stout
>            Reporter: Cody Maloney
>            Assignee: Isabel Jimenez
>              Labels: mesosphere, tech-debt
>
> Currently stout os::read() has two radically different implementations when you give
it a {{std::string}} vs. a {{const char *}}. Ideally these have one implementation that does
things like intelligently size the buffer that it writes into rather than re-allocating repeatedly
with every time it lengthens the string (resulting in copious copying). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message