Return-Path: X-Original-To: apmail-mesos-issues-archive@minotaur.apache.org Delivered-To: apmail-mesos-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 60736189BC for ; Wed, 27 Jan 2016 23:29:45 +0000 (UTC) Received: (qmail 43562 invoked by uid 500); 27 Jan 2016 23:29:40 -0000 Delivered-To: apmail-mesos-issues-archive@mesos.apache.org Received: (qmail 43526 invoked by uid 500); 27 Jan 2016 23:29:40 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 43507 invoked by uid 99); 27 Jan 2016 23:29:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Jan 2016 23:29:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E37742C1F54 for ; Wed, 27 Jan 2016 23:29:39 +0000 (UTC) Date: Wed, 27 Jan 2016 23:29:39 +0000 (UTC) From: "Joseph Wu (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-4536) Add abstractions of "owned" and "shared" file descriptors to libprocess. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MESOS-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120401#comment-15120401 ] Joseph Wu commented on MESOS-4536: ---------------------------------- It should be fine to combine the issues. Although, we specifically also need {{Owned}} FDs (not just reference counted FDs). > Add abstractions of "owned" and "shared" file descriptors to libprocess. > ------------------------------------------------------------------------ > > Key: MESOS-4536 > URL: https://issues.apache.org/jira/browse/MESOS-4536 > Project: Mesos > Issue Type: Improvement > Components: libprocess > Reporter: Joseph Wu > Assignee: Joseph Wu > > Libprocess currently manages file descriptors as plain {{int}} s. This leads to some easily missed bugs regarding duplicated or closed FDs. > We should introduce an abstraction (like {{unique_ptr}} and {{shared_ptr}}) so that FD ownership can be expressed alongside the affected code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)