mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Mahler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-4075) Continue test suite execution across crashing tests.
Date Tue, 05 Jan 2016 00:58:39 GMT

    [ https://issues.apache.org/jira/browse/MESOS-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082126#comment-15082126
] 

Benjamin Mahler commented on MESOS-4075:
----------------------------------------

The tests shouldn't be crashing though, why don't we focus on fixing crashes instead? For
example, we currently have memory management issues that cause a test failures to unnecessarily
cause the test binary to crash. Consider [this snippet|https://github.com/apache/mesos/blob/0.26.0/src/tests/slave_tests.cpp#L256-L259],
where we pass a pointer to a stack allocated object into the slave / test abstractions, this
means that if an assertion fails in the test, the code may crash!

> Continue test suite execution across crashing tests.
> ----------------------------------------------------
>
>                 Key: MESOS-4075
>                 URL: https://issues.apache.org/jira/browse/MESOS-4075
>             Project: Mesos
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.26.0
>            Reporter: Bernd Mathiske
>              Labels: mesosphere
>
> Currently, mesos-tests.sh exits when a test crashes. This is inconvenient when trying
to find out all tests that fail. 
> mesos-tests.sh should rate a test that crashes as failed and continue the same way as
if the test merely returned with a failure result and exited properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message