Return-Path: X-Original-To: apmail-mesos-issues-archive@minotaur.apache.org Delivered-To: apmail-mesos-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6D83A18808 for ; Sat, 5 Dec 2015 02:18:16 +0000 (UTC) Received: (qmail 19656 invoked by uid 500); 5 Dec 2015 02:18:11 -0000 Delivered-To: apmail-mesos-issues-archive@mesos.apache.org Received: (qmail 19612 invoked by uid 500); 5 Dec 2015 02:18:11 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 19495 invoked by uid 99); 5 Dec 2015 02:18:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Dec 2015 02:18:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0D31C2C1F70 for ; Sat, 5 Dec 2015 02:18:11 +0000 (UTC) Date: Sat, 5 Dec 2015 02:18:11 +0000 (UTC) From: "Klaus Ma (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-1718) Command executor can overcommit the slave. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MESOS-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15042587#comment-15042587 ] Klaus Ma commented on MESOS-1718: --------------------------------- [~idownes], yes; it asked slave to report patch to master in my draft RR, so master build the executor for command line. And I cut some resources from task resources to command line executor, e.g. 1 CPU command line tasks will use 0.1 GPU for executor & 0.9 for task. Regarding ExecutorInfo, i'd like to add {{CommandInfo task_command}} into {{ExecutorInfo}}; I'd like to build a new executor info for command line tasks, the task's command line info are in {{task_command}}, command line executor info are in {{ExecutorInfo}}. > Command executor can overcommit the slave. > ------------------------------------------ > > Key: MESOS-1718 > URL: https://issues.apache.org/jira/browse/MESOS-1718 > Project: Mesos > Issue Type: Bug > Components: slave > Reporter: Benjamin Mahler > Assignee: Ian Downes > > Currently we give a small amount of resources to the command executor, in addition to resources used by the command task: > https://github.com/apache/mesos/blob/0.20.0-rc1/src/slave/slave.cpp#L2448 > {code: title=} > ExecutorInfo Slave::getExecutorInfo( > const FrameworkID& frameworkId, > const TaskInfo& task) > { > ... > // Add an allowance for the command executor. This does lead to a > // small overcommit of resources. > executor.mutable_resources()->MergeFrom( > Resources::parse( > "cpus:" + stringify(DEFAULT_EXECUTOR_CPUS) + ";" + > "mem:" + stringify(DEFAULT_EXECUTOR_MEM.megabytes())).get()); > ... > } > {code} > This leads to an overcommit of the slave. Ideally, for command tasks we can "transfer" all of the task resources to the executor at the slave / isolation level. -- This message was sent by Atlassian JIRA (v6.3.4#6332)