Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Date: Wed, 4 Nov 2015 03:34:27 +0000 (UTC)
From: "Stephen Degler (JIRA)" <jira@apache.org>
To: issues@mesos.apache.org
Message-ID: <JIRA.12906838.1445453100000.146213.1446608067721@Atlassian.JIRA>
In-Reply-To: <JIRA.12906838.1445453100000@Atlassian.JIRA>
References: <JIRA.12906838.1445453100000@Atlassian.JIRA>
 <JIRA.12906838.1445453100696@arcas>
Subject: [jira] [Commented] (MESOS-3787) As a developer, I'd like to be able
 to expand environment variables through the Docker executor.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MESOS-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14988821#comment-14988821 ] 

Stephen Degler commented on MESOS-3787:
---------------------------------------

My horrible hack :-)

        "volumes": [
            {

                "containerPath": "/${KRB5CCNAME}",
                "hostPath": "/${KRB5CCNAME}",
                "mode": "RO"
            }
        ]

So the nice thing about our patch was that substitutions were done earlier.  its wrong because we probably leak memory as we didn't want to change the mutability of taskInfo.  Your patch is much smaller, but then the subsequent logic examines the arguments prior to expansion and goofs up the paths at least.


> As a developer, I'd like to be able to expand environment variables through the Docker executor.
> ------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-3787
>                 URL: https://issues.apache.org/jira/browse/MESOS-3787
>             Project: Mesos
>          Issue Type: Wish
>            Reporter: John Garcia
>              Labels: mesosphere
>         Attachments: mesos.patch, test-example.json
>
>
> We'd like to have expanded variables usable in [the json files used to create a Marathon app, hence] the Task's CommandInfo, so that the executor is able to detect the correct values at runtime.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)