mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MESOS-3863) Investigate the requirements of programmatically re-initializing libprocess
Date Tue, 10 Nov 2015 01:02:11 GMT

     [ https://issues.apache.org/jira/browse/MESOS-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joseph Wu updated MESOS-3863:
-----------------------------
    Description: 
This issue is for investigating what needs to be added/changed in {{process::finalize}} such
that {{process::initialize}} will start on a clean slate.  Additional issues will be created
once done.  Also see [the parent issue|MESOS-3820].

{{process::finalize}} should cover the following components:
* {{__s__}} (the server socket)
** {{delete}} should be sufficient.  This closes the socket and thereby prevents any further
interaction from it.
* {{process_manager}}
** Related prior work: [MESOS-3158]
** Cleans up the garbage collector, help, logging, profiler, statistics, route processes (including
[this one|https://github.com/apache/mesos/blob/3bda55da1d0b580a1b7de43babfdc0d30fbc87ea/3rdparty/libprocess/src/process.cpp#L963],
which currently leaks a pointer).
** Cleans up any other {{spawn}} 'd process.
** Manages the {{EventLoop}}.
* {{Clock}}
** The goal here is to clear any timers so that nothing can deference {{process_manager}}
while we're finalizing/finalized.  It's probably not important to execute any remaining timers,
since we're "shutting down" libprocess.  This means:
*** The clock should be {{paused}} and {{settled}} before the clean up of {{process_manager}}.
*** Processes, which might interact with the {{Clock}}, should be cleaned up next.
*** A new {{Clock::finalize}} method would then clear timers, process-specific clocks, and
{{tick}} s; and then {{resume}} the clock.
* {{__address__}} (the advertised IP and port)
** Needs to be cleared after {{process_manager}} has been cleaned up.  Processes use this
to communicate events.  If cleared prematurely, {{TerminateEvents}} will not be sent correctly,
leading to infinite waits.
* {{socket_manager}}
** The idea here is to close all sockets and deallocate any existing {{HttpProxy}} or {{Encoder}}
objects.
** All sockets are created via {{__s__}}, so cleaning up the server socket prior will prevent
any new activity.
* {{mime}}
** This is effectively a static map.
** It should be possible to statically initialize it.
* Synchronization atomics {{initialized}} & {{initializing}}.
** Once cleanup is done, these should be reset.

(Note: the list above is still incomplete/under-investigation.)

  was:
This issue is for investigating what needs to be added/changed in {{process::finalize}} such
that {{process::initialize}} will start on a clean slate.  Additional issues will be created
once done.  Also see [the parent issue|MESOS-3820].

*{{process::initialize}} covers the following components:*
* {{process_manager}}
** Related prior work: [MESOS-3158]
** Cleans up the garbage collector, help, logging, profiler, statistics, route processes (including
[this one|https://github.com/apache/mesos/blob/3bda55da1d0b580a1b7de43babfdc0d30fbc87ea/3rdparty/libprocess/src/process.cpp#L963],
which currently leaks a pointer).
** Cleans up any other {{spawn}} 'd process.
* {{socket_manager}}
* {{EventLoop}}
* {{Clock}}
** The goal here is to clear any timers so that nothing can deference {{process_manager}}
while we're finalizing/finalized.  It's probably not important to execute any remaining timers,
since we're "shutting down" libprocess.  This means:
*** The clock should be {{paused}} and {{settled}} before the clean up of {{process_manager}}.
*** Processes, which might interact with the {{Clock}}, should be cleaned up next.
*** A new {{Clock::finalize}} method would then clear timers, process-specific clocks, and
{{tick}} s; and then {{resume}} the clock.
* {{__s__}}
** {{delete}} should be sufficient.
* {{__address__}}
** Needs to be cleared after {{process_manager}} has been cleaned up.  Processes use this
to communicate events.  If cleared prematurely, {{TerminateEvents}} will not be sent correctly,
leading to infinite waits.
* {{mime}}
** This is effectively a static map.
** It should be possible to statically initialize it.
* Synchronization atomics {{initialized}} & {{initializing}}.
** Once cleanup is done, these should be reset.

(Note: the list above is still incomplete/under-investigation.)


> Investigate the requirements of programmatically re-initializing libprocess
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-3863
>                 URL: https://issues.apache.org/jira/browse/MESOS-3863
>             Project: Mesos
>          Issue Type: Task
>          Components: libprocess, test
>            Reporter: Joseph Wu
>            Assignee: Joseph Wu
>              Labels: mesosphere
>
> This issue is for investigating what needs to be added/changed in {{process::finalize}}
such that {{process::initialize}} will start on a clean slate.  Additional issues will be
created once done.  Also see [the parent issue|MESOS-3820].
> {{process::finalize}} should cover the following components:
> * {{__s__}} (the server socket)
> ** {{delete}} should be sufficient.  This closes the socket and thereby prevents any
further interaction from it.
> * {{process_manager}}
> ** Related prior work: [MESOS-3158]
> ** Cleans up the garbage collector, help, logging, profiler, statistics, route processes
(including [this one|https://github.com/apache/mesos/blob/3bda55da1d0b580a1b7de43babfdc0d30fbc87ea/3rdparty/libprocess/src/process.cpp#L963],
which currently leaks a pointer).
> ** Cleans up any other {{spawn}} 'd process.
> ** Manages the {{EventLoop}}.
> * {{Clock}}
> ** The goal here is to clear any timers so that nothing can deference {{process_manager}}
while we're finalizing/finalized.  It's probably not important to execute any remaining timers,
since we're "shutting down" libprocess.  This means:
> *** The clock should be {{paused}} and {{settled}} before the clean up of {{process_manager}}.
> *** Processes, which might interact with the {{Clock}}, should be cleaned up next.
> *** A new {{Clock::finalize}} method would then clear timers, process-specific clocks,
and {{tick}} s; and then {{resume}} the clock.
> * {{__address__}} (the advertised IP and port)
> ** Needs to be cleared after {{process_manager}} has been cleaned up.  Processes use
this to communicate events.  If cleared prematurely, {{TerminateEvents}} will not be sent
correctly, leading to infinite waits.
> * {{socket_manager}}
> ** The idea here is to close all sockets and deallocate any existing {{HttpProxy}} or
{{Encoder}} objects.
> ** All sockets are created via {{__s__}}, so cleaning up the server socket prior will
prevent any new activity.
> * {{mime}}
> ** This is effectively a static map.
> ** It should be possible to statically initialize it.
> * Synchronization atomics {{initialized}} & {{initializing}}.
> ** Once cleanup is done, these should be reset.
> (Note: the list above is still incomplete/under-investigation.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message