Return-Path: X-Original-To: apmail-mesos-issues-archive@minotaur.apache.org Delivered-To: apmail-mesos-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7228618401 for ; Wed, 21 Oct 2015 15:07:34 +0000 (UTC) Received: (qmail 37298 invoked by uid 500); 21 Oct 2015 15:07:28 -0000 Delivered-To: apmail-mesos-issues-archive@mesos.apache.org Received: (qmail 37185 invoked by uid 500); 21 Oct 2015 15:07:28 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 37097 invoked by uid 99); 21 Oct 2015 15:07:28 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Oct 2015 15:07:28 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id ED0EB2C1F69 for ; Wed, 21 Oct 2015 15:07:27 +0000 (UTC) Date: Wed, 21 Oct 2015 15:07:27 +0000 (UTC) From: "Joris Van Remoortere (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MESOS-3326) Make use of C++11 atomics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MESOS-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joris Van Remoortere updated MESOS-3326: ---------------------------------------- Labels: mesosphere (was: ) > Make use of C++11 atomics > ------------------------- > > Key: MESOS-3326 > URL: https://issues.apache.org/jira/browse/MESOS-3326 > Project: Mesos > Issue Type: Bug > Reporter: Neil Conway > Assignee: Neil Conway > Labels: mesosphere > Fix For: 0.26.0 > > > Now that we require C++11, we can make use of std::atomic. For example: > * libprocess/process.cpp uses a bare int + __sync_synchronize() for "running" > * __sync_synchronize() is used in logging.hpp in libprocess and fork.hpp in stout > * sched/sched.cpp uses a volatile int for "running" -- this is wrong, "volatile" is not sufficient to ensure safe concurrent access > * "volatile" is used in a few other places -- most are probably dubious but I haven't looked closely -- This message was sent by Atlassian JIRA (v6.3.4#6332)