Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Date: Fri, 28 Aug 2015 17:37:45 +0000 (UTC)
From: "Neil Conway (JIRA)" <jira@apache.org>
To: issues@mesos.apache.org
Message-ID: <JIRA.12859903.1440765089000.196487.1440783465816@Atlassian.JIRA>
In-Reply-To: <JIRA.12859903.1440765089000@Atlassian.JIRA>
References: <JIRA.12859903.1440765089000@Atlassian.JIRA>
 <JIRA.12859903.1440765089438@arcas>
Subject: [jira] [Commented] (MESOS-3329) Unused hashmap::existsValue
 functions have incomplete code paths
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MESOS-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14720297#comment-14720297 ] 

Neil Conway commented on MESOS-3329:
------------------------------------

If it is unused, I'd vote for removing it.

> Unused hashmap::existsValue functions have incomplete code paths
> ----------------------------------------------------------------
>
>                 Key: MESOS-3329
>                 URL: https://issues.apache.org/jira/browse/MESOS-3329
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout
>            Reporter: Jan Schlicht
>            Priority: Trivial
>              Labels: easyfix, mesosphere
>
> `stout/hashmap.hpp` defines functions `hashmap::existsValue`. These return true if a certain value exists in the hashmap instance. The control flow of these functions doesn't cover the case that the value is not found, which should result in false. Right now the result in this case is undefined.
> As the `existsValue` functions are never called this doesn't result in a compile error atm.
> Possible solutions:
> 1) Add `return false`
> 2) Remove function


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)