mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-3245) The comments of DRFSorter::dirty is not correct
Date Thu, 27 Aug 2015 15:01:46 GMT

    [ https://issues.apache.org/jira/browse/MESOS-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716803#comment-14716803
] 

Michael Park commented on MESOS-3245:
-------------------------------------

Thanks for this Qian! I've committed this patch for you.

{noformat}
commit 3b91e35b458ffbf1f99c28e1540cb55f7f7d7454
Author: Qian Zhang <zhangqxa@cn.ibm.com>
Date:   Thu Aug 27 10:52:22 2015 -0400

    Corrected the inaccurate description of 'DRFSorter::dirty'.

    Review: https://reviews.apache.org/r/37289
{noformat}

> The comments of DRFSorter::dirty is not correct
> -----------------------------------------------
>
>                 Key: MESOS-3245
>                 URL: https://issues.apache.org/jira/browse/MESOS-3245
>             Project: Mesos
>          Issue Type: Bug
>          Components: allocation
>            Reporter: Qian Zhang
>            Assignee: Qian Zhang
>            Priority: Minor
>             Fix For: 0.25.0
>
>
> The comment is:
> {code}
>   // If true, start() will recalculate all shares.
>   bool dirty;
> {code}
> But there is actually no start() method in class DRFSorter, I think the comment should
be:
> {code}
>   // If true, sort() will recalculate all shares.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message