Return-Path: 
 <issues-return-11417-apmail-mesos-issues-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-issues-archive@minotaur.apache.org
Delivered-To: apmail-mesos-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 399F018231
	for <apmail-mesos-issues-archive@minotaur.apache.org>;
 Mon,  6 Jul 2015 02:35:05 +0000 (UTC)
Received: (qmail 57711 invoked by uid 500); 6 Jul 2015 02:35:05 -0000
Delivered-To: apmail-mesos-issues-archive@mesos.apache.org
Received: (qmail 57683 invoked by uid 500); 6 Jul 2015 02:35:05 -0000
Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@mesos.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@mesos.apache.org>
List-Post: <mailto:issues@mesos.apache.org>
List-Id: <issues.mesos.apache.org>
Reply-To: dev@mesos.apache.org
Delivered-To: mailing list issues@mesos.apache.org
Received: (qmail 57673 invoked by uid 99); 6 Jul 2015 02:35:05 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Jul 2015 02:35:05 +0000
Date: Mon, 6 Jul 2015 02:35:04 +0000 (UTC)
From: "Benjamin Hindman (JIRA)" <jira@apache.org>
To: issues@mesos.apache.org
Message-ID: <JIRA.12841797.1435698249000.102090.1436150104954@Atlassian.JIRA>
In-Reply-To: <JIRA.12841797.1435698249000@Atlassian.JIRA>
References: <JIRA.12841797.1435698249000@Atlassian.JIRA>
 <JIRA.12841797.1435698249437@arcas>
Subject: [jira] [Commented] (MESOS-2965) Stout os functions don't take Path
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/MESOS-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614490#comment-14614490 ] 

Benjamin Hindman commented on MESOS-2965:
-----------------------------------------

FYI, I like keeping construction of Path explicit right now, so folks can clearly see where we go from strings to Paths in the code base. I'm okay with an explicit Path -> std::string operator for now too, but ultimately we should really make these functions take a Path object for even greater code/type safety.

> Stout os functions don't take Path 
> -----------------------------------
>
>                 Key: MESOS-2965
>                 URL: https://issues.apache.org/jira/browse/MESOS-2965
>             Project: Mesos
>          Issue Type: Improvement
>          Components: stout
>            Reporter: Artem Harutyunyan
>            Assignee: Joseph Wu
>            Priority: Minor
>              Labels: beginner, mesosphere, newbie, stout
>
> For example:
> {code}inline Try<Nothing> rm(const std::string& path){code} does not have an overload for {code}inline Try<Nothing> rm(const Path& path){code}
> The implementation should be something like: 
> {code}
> inline Try<Nothing> rm(const Path& path)
> {
>   rm(path.value);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)