mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-2965) Stout os functions don't take Path
Date Mon, 06 Jul 2015 02:35:04 GMT

    [ https://issues.apache.org/jira/browse/MESOS-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614490#comment-14614490
] 

Benjamin Hindman commented on MESOS-2965:
-----------------------------------------

FYI, I like keeping construction of Path explicit right now, so folks can clearly see where
we go from strings to Paths in the code base. I'm okay with an explicit Path -> std::string
operator for now too, but ultimately we should really make these functions take a Path object
for even greater code/type safety.

> Stout os functions don't take Path 
> -----------------------------------
>
>                 Key: MESOS-2965
>                 URL: https://issues.apache.org/jira/browse/MESOS-2965
>             Project: Mesos
>          Issue Type: Improvement
>          Components: stout
>            Reporter: Artem Harutyunyan
>            Assignee: Joseph Wu
>            Priority: Minor
>              Labels: beginner, mesosphere, newbie, stout
>
> For example:
> {code}inline Try<Nothing> rm(const std::string& path){code} does not have an
overload for {code}inline Try<Nothing> rm(const Path& path){code}
> The implementation should be something like: 
> {code}
> inline Try<Nothing> rm(const Path& path)
> {
>   rm(path.value);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message