mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Williams (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MESOS-2637) Consolidate 'foo', 'bar', ... string constants in test and example code
Date Mon, 22 Jun 2015 11:28:00 GMT

     [ https://issues.apache.org/jira/browse/MESOS-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Colin Williams updated MESOS-2637:
----------------------------------
    Description: We are using 'foo', 'bar', ... string constants and pairs in src/tests/master_tests.cpp,
src/tests/slave_tests.cpp, src/tests/hook_tests.cpp and src/examples/test_hook_module.cpp
for label and hooks tests. These values should be stored in local variables to avoid the possibility
of assignment getting out of sync with checking for that same value.  (was: We are using 'foo',
'bar', ... string constants and pairs in src/tests/master_tests.cpp, src/tests/slave_tests.cpp,
src/tests/hook_tests.cpp and src/examples/test_hook_module.cpp for label and hooks tests.
We should consolidate them to make the call sites less prone to forgetting to update all call
sites.)

> Consolidate 'foo', 'bar', ... string constants in test and example code
> -----------------------------------------------------------------------
>
>                 Key: MESOS-2637
>                 URL: https://issues.apache.org/jira/browse/MESOS-2637
>             Project: Mesos
>          Issue Type: Bug
>          Components: technical debt
>            Reporter: Niklas Quarfot Nielsen
>            Assignee: Colin Williams
>
> We are using 'foo', 'bar', ... string constants and pairs in src/tests/master_tests.cpp,
src/tests/slave_tests.cpp, src/tests/hook_tests.cpp and src/examples/test_hook_module.cpp
for label and hooks tests. These values should be stored in local variables to avoid the possibility
of assignment getting out of sync with checking for that same value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message