mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-2210) Disallow special characters in role.
Date Sun, 21 Jun 2015 14:22:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595059#comment-14595059
] 

haosdent commented on MESOS-2210:
---------------------------------

[~adam-mesos][~jieyu] I write a sample patch here. https://reviews.apache.org/r/35711/ 
I disallow space character, backspace, slash in role name. And also disallow role name is
'.' or starts with '-'.

But I have some questions now:
1. Do we need check role name in Authorizer::create?
2. Do we need check role name in Master::validate?

Looking forward your reply, and then I could update the patch for review. Thank you in advance.

> Disallow special characters in role.
> ------------------------------------
>
>                 Key: MESOS-2210
>                 URL: https://issues.apache.org/jira/browse/MESOS-2210
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Jie Yu
>              Labels: newbie
>
> As we introduce persistent volumes in MESOS-1524, we will use roles as directory names
on the slave (https://reviews.apache.org/r/28562/). As a result, the master should disallow
special characters (like space and slash) in role.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message