mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Williams (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-2637) Consolidate 'foo', 'bar', ... string constants in test and example code
Date Mon, 18 May 2015 17:03:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548287#comment-14548287
] 

Colin Williams commented on MESOS-2637:
---------------------------------------

Alright I've put a change up for review (https://reviews.apache.org/r/34361/) representing
what I think is wanted from this issue, let me know if I should change anything.

> Consolidate 'foo', 'bar', ... string constants in test and example code
> -----------------------------------------------------------------------
>
>                 Key: MESOS-2637
>                 URL: https://issues.apache.org/jira/browse/MESOS-2637
>             Project: Mesos
>          Issue Type: Bug
>          Components: technical debt
>            Reporter: Niklas Quarfot Nielsen
>            Assignee: Colin Williams
>
> We are using 'foo', 'bar', ... string constants and pairs in src/tests/master_tests.cpp,
src/tests/slave_tests.cpp, src/tests/hook_tests.cpp and src/examples/test_hook_module.cpp
for label and hooks tests. We should consolidate them to make the call sites less prone to
forgetting to update all call sites.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message