mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-2565) Clean up style and comments in modules.
Date Wed, 01 Apr 2015 09:29:53 GMT

    [ https://issues.apache.org/jira/browse/MESOS-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390276#comment-14390276
] 

Alexander Rukletsov commented on MESOS-2565:
--------------------------------------------

Yes, that's exactly what I mean.

> Clean up style and comments in modules.
> ---------------------------------------
>
>                 Key: MESOS-2565
>                 URL: https://issues.apache.org/jira/browse/MESOS-2565
>             Project: Mesos
>          Issue Type: Improvement
>          Components: modules
>            Reporter: Alexander Rukletsov
>            Priority: Minor
>              Labels: easyfix, newbie
>
> We have some minor style issues in modules code. This ticket aims to clean them up.
> ----
> *{{s/template<>/template <>/}}*
> Affected files:
> include/mesos/module/authenticatee.hpp
> include/mesos/module/authenticator.hpp
> include/mesos/module/hook.hpp
> include/mesos/module/isolator.hpp
> src/examples/test_module.hpp
> *Move { } onto the previous line in Module c-tors*
> Affected files:
> include/mesos/module/authenticatee.hpp
> include/mesos/module/authenticator.hpp
> include/mesos/module/hook.hpp
> include/mesos/module/isolator.hpp
> src/examples/test_module.hpp
> *Misleading comments in test modules.*
> Module name is an exported symbol. Comments on module declaration should reflect this.
Affected files:
> src/examples/test_anonymous_module.cpp
> src/examples/test_hook_module.cpp
> src/examples/test_isolator_module.cpp



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message