mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evelina Dumitrescu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MESOS-1919) Create IP address abstraction
Date Fri, 24 Oct 2014 20:55:34 GMT

    [ https://issues.apache.org/jira/browse/MESOS-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183448#comment-14183448
] 

Evelina Dumitrescu edited comment on MESOS-1919 at 10/24/14 8:55 PM:
---------------------------------------------------------------------

After serveral discussions, I have proposed the following structure:
{noformat}
struct IPAddress {
   uint8_t family;
   union {
       struct in_addr ipv4_address;
       struct in6_addr ipv6_address;
   };
};
{noformat}
Is everybody okay to stick to this representation?


was (Author: evelinad):
After serveral discussions, I have proposed the following structure:

struct IPAddress {
   uint8_t family;
   union {
       struct in_addr ipv4_address;
       struct in6_addr ipv6_address;
   };
};

Is everybody okay to stick to this representation?

> Create IP address abstraction
> -----------------------------
>
>                 Key: MESOS-1919
>                 URL: https://issues.apache.org/jira/browse/MESOS-1919
>             Project: Mesos
>          Issue Type: Task
>          Components: libprocess
>            Reporter: Dominic Hamon
>            Assignee: Evelina Dumitrescu
>            Priority: Minor
>
> in the code many functions need only the ip address to be passed as a parameter. I don't
think it would be desirable to use a struct SockaddrStorage (MESOS-1916).
> Consider using a {{std::vector<unsigned char>}} (see {{typedef std::vector<unsigned
char> IPAddressNumber;}} in the Chromium project)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message