mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cody Maloney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-1742) Remove Using Directives
Date Thu, 28 Aug 2014 17:54:09 GMT

    [ https://issues.apache.org/jira/browse/MESOS-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114057#comment-14114057
] 

Cody Maloney commented on MESOS-1742:
-------------------------------------

I definitely agree on that point. The coding standard should either be updated or things should
be brought inline over time. 

There are arguments about of code which utilizes using statements to grab entire namespaces
(bits of libprocess and stout don't use a lot of namespaces though, and there seems to be
a tendency to hand-prefix things like local functions to make them not collide, rather than
using the 'static' keyword in cc files and dropping things in namespaces in headers).

> Remove Using Directives
> -----------------------
>
>                 Key: MESOS-1742
>                 URL: https://issues.apache.org/jira/browse/MESOS-1742
>             Project: Mesos
>          Issue Type: Story
>          Components: build
>            Reporter: Jessica Hartog
>              Labels: build
>
> We tell developers to follow the Google C++ Style Guide (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml)
which says, "Do not use a using-directive."
> At the moment 134 files in src/ do not conform to this practice.
> $ grep -r -l "using namespace" src | wc -l
> 134
> Using directives increase compile time by requiring a larger lookup space for unqualified
ids.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message