From dev-return-50567-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Sat Jun 23 06:13:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F379918067A for ; Sat, 23 Jun 2018 06:13:04 +0200 (CEST) Received: (qmail 57524 invoked by uid 500); 23 Jun 2018 04:12:58 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 57513 invoked by uid 99); 23 Jun 2018 04:12:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Jun 2018 04:12:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B0297C049C for ; Sat, 23 Jun 2018 04:12:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.301 X-Spam-Level: X-Spam-Status: No, score=-2.301 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Ua1Sa1pGxf6D for ; Sat, 23 Jun 2018 04:12:54 +0000 (UTC) Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.141]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 7EA325F288 for ; Sat, 23 Jun 2018 04:12:54 +0000 (UTC) Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 8662F21176 for ; Sat, 23 Jun 2018 06:12:47 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 41CMV66cldz9rxD for ; Sat, 23 Jun 2018 06:12:46 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 22 Jun 2018 21:12:46 -0700 From: Andrew Schwartzmeyer To: dev@mesos.apache.org Subject: Re: Getting write access to our GitHub repo In-Reply-To: <2AA65FD8-E9D4-4E6F-A14F-62CB3E490CCB@gmail.com> References: <2AA65FD8-E9D4-4E6F-A14F-62CB3E490CCB@gmail.com> Message-ID: X-Sender: andrew@schwartzmeyer.com User-Agent: Posteo Webmail GitHub PR code reviews have gotten _significantly_ better over the last two years. You can actually open addressable issues now (like ReviewBoard), and assign reviewers, and "officially" mark it as signed-off (ship-it) too. They used to suck so bad that I preferred inline email comments to PRs, but they've improved. On 06/22/2018 9:01 pm, James Peach wrote: >> On Jun 22, 2018, at 7:34 PM, Jie Yu wrote: >> >> +1 >> >> Does this means we can add CI webhooks to the git repo? > > FWIW, I'm hugely -1 on doing code reviews on GitHub. I'm cautiously > optimistic about other kinds of integration though. > >> On Thu, Jun 21, 2018 at 3:45 PM, James Peach wrote: >> >>> >>> >>>> On Jun 20, 2018, at 7:58 PM, Vinod Kone >>>> wrote: >>>> >>>> Hi folks, >>>> >>>> Looks like ASF now supports giving >>>> write >>>> access to committers for their GitHub mirrors, which means we can >>>> merge >>> PRs >>>> directly on GitHub! >>> >>> Are you proposing that we move to Github generally? >>> >>>> FWICT, this requires us moving our repo to a new gitbox server by >>>> filing >>> an >>>> INFRA ticket. We probably need to update our CI and other tooling >>>> that >>>> references our git repo directly, so there will be work involved on >>>> our >>> end >>>> as well. >>>> >>>> This has been one of the long requested features from several >>>> committers, >>>> so I'm gauging interest to see if folks think we should go down this >>> route >>>> (several projects seem to be already moving >>>> ) >>> too. >>>> >>>> If there is enough interest, we could start a vote. >>>> >>>> Thanks, >>>> Vinod >>> >>>