From dev-return-50571-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Mon Jun 25 10:56:32 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0CEB3180627 for ; Mon, 25 Jun 2018 10:56:31 +0200 (CEST) Received: (qmail 4643 invoked by uid 500); 25 Jun 2018 08:56:30 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 4626 invoked by uid 99); 25 Jun 2018 08:56:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2018 08:56:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 04611E0A42; Mon, 25 Jun 2018 08:56:30 +0000 (UTC) From: qianzhangxa To: dev@mesos.apache.org Reply-To: dev@mesos.apache.org References: In-Reply-To: Subject: [GitHub] mesos pull request #299: Fix orphaning CNI network on recovery. Content-Type: text/plain Message-Id: <20180625085630.04611E0A42@git1-us-west.apache.org> Date: Mon, 25 Jun 2018 08:56:30 +0000 (UTC) Github user qianzhangxa commented on a diff in the pull request: https://github.com/apache/mesos/pull/299#discussion_r197723026 --- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp --- @@ -428,6 +428,10 @@ Future NetworkCniIsolatorProcess::recover( } } + if (infos.contains(containerId)) { --- End diff -- This will make the unknown orphaned containers are skipped (i.e., we will miss to do cleanup for unknown orphaned container). So I would suggest to just do a `continue;` between L420 and L421. @vixns Do you want to post a patch in https://reviews.apache.org/? ---