mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Getting write access to our GitHub repo
Date Sat, 23 Jun 2018 12:54:50 GMT
That’s right. Reviewboard will still be supported after the move. Just makes GH side if things
better. 

Thanks,
Vinod

> On Jun 23, 2018, at 4:48 AM, Chun-Hung Hsiao <chhsiao@mesosphere.io> wrote:
> 
> I also find GitHub hard to do code review. If we put multiple commits in a
> PR where each commit has a specific purpose, then after the author revises
> each commit, it would hard to see what has been updated between two
> revisions of "the same commit." If we put a review chain into multiple PRs
> where each PR has a specific purpose and make each revision a new commit,
> then it's hard to specify dependencies between PRs.
> 
>> On Fri, Jun 22, 2018, 10:23 PM Yan Xu <yan@jxu.me> wrote:
>> 
>> IIUC this wouldn't necessarily rule out RB reviews just better support for
>> Github PRs?
>> 
>> On Fri, Jun 22, 2018 at 9:13 PM Andrew Schwartzmeyer <
>> andrew@schwartzmeyer.com> wrote:
>> 
>>> GitHub PR code reviews have gotten _significantly_ better over the last
>>> two years. You can actually open addressable issues now (like
>>> ReviewBoard), and assign reviewers, and "officially" mark it as
>>> signed-off (ship-it) too. They used to suck so bad that I preferred
>>> inline email comments to PRs, but they've improved.
>>> 
>>> On 06/22/2018 9:01 pm, James Peach wrote:
>>>>> On Jun 22, 2018, at 7:34 PM, Jie Yu <yujie.jay@gmail.com> wrote:
>>>>> 
>>>>> +1
>>>>> 
>>>>> Does this means we can add CI webhooks to the git repo?
>>>> 
>>>> FWIW, I'm hugely -1 on doing code reviews on GitHub. I'm cautiously
>>>> optimistic about other kinds of integration though.
>>>> 
>>>>> On Thu, Jun 21, 2018 at 3:45 PM, James Peach <jorgar@gmail.com>
>> wrote:
>>>>> 
>>>>>> 
>>>>>> 
>>>>>>> On Jun 20, 2018, at 7:58 PM, Vinod Kone <vinodkone@apache.org>
>>>>>>> wrote:
>>>>>>> 
>>>>>>> Hi folks,
>>>>>>> 
>>>>>>> Looks like ASF now supports <https://gitbox.apache.org/>
giving
>>>>>>> write
>>>>>>> access to committers for their GitHub mirrors, which means we
can
>>>>>>> merge
>>>>>> PRs
>>>>>>> directly on GitHub!
>>>>>> 
>>>>>> Are you proposing that we move to Github generally?
>>>>>> 
>>>>>>> FWICT, this requires us moving our repo to a new gitbox server
by
>>>>>>> filing
>>>>>> an
>>>>>>> INFRA ticket. We probably need to update our CI and other tooling
>>>>>>> that
>>>>>>> references our git repo directly, so there will be work involved
on
>>>>>>> our
>>>>>> end
>>>>>>> as well.
>>>>>>> 
>>>>>>> This has been one of the long requested features from several
>>>>>>> committers,
>>>>>>> so I'm gauging interest to see if folks think we should go down
this
>>>>>> route
>>>>>>> (several projects seem to be already moving
>>>>>>> <https://issues.apache.org/jira/issues/?jql=text%20~%20%22gitbox%22
>>> )
>>>>>> too.
>>>>>>> 
>>>>>>> If there is enough interest, we could start a vote.
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> Vinod
>>>>>> 
>>>>>> 
>>> 
>> 

Mime
View raw message