mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vixns <...@git.apache.org>
Subject [GitHub] mesos pull request #299: Fix orphaning CNI network on recovery.
Date Mon, 25 Jun 2018 09:53:37 GMT
Github user vixns commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/299#discussion_r197739766
  
    --- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
    @@ -428,6 +428,10 @@ Future<Nothing> NetworkCniIsolatorProcess::recover(
           }
         }
     
    +    if (infos.contains(containerId)) {
    +      continue;
    +    }
    +
    --- End diff --
    
    Understood, L421 is for orphaned tasks only, and in this case the L437 test matches.
    So you're right, moving the continue to L421 make sense.



---

Mime
View raw message