mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From qianzhangxa <...@git.apache.org>
Subject [GitHub] mesos pull request #299: Fix orphaning CNI network on recovery.
Date Mon, 25 Jun 2018 09:35:13 GMT
Github user qianzhangxa commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/299#discussion_r197734403
  
    --- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
    @@ -428,6 +428,10 @@ Future<Nothing> NetworkCniIsolatorProcess::recover(
           }
         }
     
    +    if (infos.contains(containerId)) {
    +      continue;
    +    }
    +
    --- End diff --
    
    Why will L423 have no effect? I mean we should just do a `continue;` for the recoverable
containers (L410 - L421), for the orphaned containers, we can still keep the current logic.


---

Mime
View raw message