mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From qianzhangxa <...@git.apache.org>
Subject [GitHub] mesos pull request #299: Fix orphaning CNI network on recovery.
Date Mon, 25 Jun 2018 08:58:14 GMT
Github user qianzhangxa commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/299#discussion_r197723561
  
    --- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
    @@ -428,6 +428,10 @@ Future<Nothing> NetworkCniIsolatorProcess::recover(
           }
         }
     
    +    if (infos.contains(containerId)) {
    +      continue;
    +    }
    +
    --- End diff --
    
    This will make the unknown orphaned containers are skipped (i.e., we will miss to do cleanup
for unknown orphaned container). So I would suggest to just do a continue; between L420 and
L421.
    
    @vixns Do you want to post a patch in https://reviews.apache.org/?


---

Mime
View raw message