mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnkord <...@git.apache.org>
Subject [GitHub] mesos pull request #290: Integrated mesos fetcher with libarchive.
Date Tue, 15 May 2018 22:24:35 GMT
GitHub user johnkord opened a pull request:

    https://github.com/apache/mesos/pull/290

    Integrated mesos fetcher with libarchive.

    After talking to @andschwa , I'm posting a pull request to github due to some issues with
binary patches on review board.  I can provide more detail if you're curious. Maybe it's a
max patch file size issue, but it cuts the patch off on a line that makes me suspect that
it's a bug.
    
    Anyway, here are the review board posts:
    
    https://reviews.apache.org/r/67118/
    https://reviews.apache.org/r/67064/
    https://reviews.apache.org/r/67065/
    https://reviews.apache.org/r/67066/
    
    Since there's no CI on github, I'll need some people to test each build scenario (CMake
on Windows, CMake + autotools on Linux). I have verified that all builds work on my systems.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnkord/mesos libarchive_final

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mesos/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #290
    
----
commit ec18ccb46c5d025d924cc9c1279eeae5b8c80600
Author: John Kordich <johnkord@...>
Date:   2018-05-15T17:02:13Z

    Added bzip2, libarchive, and xz tarballs.
    
    Review: https://reviews.apache.org/r/67118

commit 80ac4677490cd320ba230fdb658d78bfda7c0c91
Author: John Kordich <johnkord@...>
Date:   2018-05-15T17:02:42Z

    Added libarchive, bzip2, and xz patches and associated build changes.
    
    These libraries being available will allow stout to be changed such that
    stout can invoke libarchive instead of shelling out to tar to extract
    archives. On Windows, tar usually doesn't exist, and even if it does, it
    rarely supports most compression formats. On Windows, we will build
    libarchive to support each of those compression formats.
    
    Review: https://reviews.apache.org/r/67064

commit 666ace4f20c6a955183a643b3195020e1d1b50c7
Author: John Kordich <johnkord@...>
Date:   2018-05-15T17:02:57Z

    Added a new stout utility header file which interfaces with libarchive.
    
    This archiver utility can be invoked to extract a compressed or
    uncompressed archive with several different supported formats.
    
    Review: https://reviews.apache.org/r/67065

commit 019c1ddc093c7ab154cc593715ccc621bb570eb9
Author: John Kordich <johnkord@...>
Date:   2018-05-15T17:03:08Z

    Modified the fetcher to use libarchive and added associated tests.
    
    Review: https://reviews.apache.org/r/67066

----


---

Mime
View raw message