mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xujyan <...@git.apache.org>
Subject [GitHub] mesos pull request #279: WIP: Remove unknown unreachable tasks when agent re...
Date Thu, 05 Apr 2018 18:11:27 GMT
Github user xujyan commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/279#discussion_r179546249
  
    --- Diff: src/master/master.cpp ---
    @@ -6805,6 +6807,7 @@ void Master::__reregisterSlave(
           Framework* framework = getFramework(frameworkId);
           if (framework != nullptr) {
             framework->unreachableTasks.erase(task.task_id());
    +        frameworkToTasks[frameworkId].erase(task.task_id());
    --- End diff --
    
    I see why you are doing this but I feel it is making things a bit more complex than necessary.
    
    Overall we are just removing tasks from `framework.unreachableTasks` from two sources,
can we just separate the two? You already have the code below that does that. See comment
below.


---

Mime
View raw message